Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-34316 Update Role Example Descriptions #629

Merged
merged 6 commits into from
Nov 17, 2023
Merged

DOCSP-34316 Update Role Example Descriptions #629

merged 6 commits into from
Nov 17, 2023

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Nov 16, 2023 •
edited
Loading

Pull Request Info

Jira

Staged Changes

Reminder Checklist

You might need to also update some corresponding pages. Check if completed or N/A.

  • Create Jira ticket for corresponding docs-realm update(s), if any
  • Checked/updated Admin API
  • Checked/updated CLI reference

Review Guidelines

REVIEWING.md

dacharyc
dacharyc approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this LGTM! But I do have a question about one of the images where it doesn't match what's in the current docs. If that is correct, then I think this is good to go - otherwise, we might need to update that one screenshot.

source/images/role-template-cannot-insert-new-docs.png Show resolved Hide resolved
@lindseymoore lindseymoore merged commit 7e5b10e into mongodb:master Nov 17, 2023
4 checks passed
@docs-builder-bot
Copy link

✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/atlas-app-services/master/

🪵 Logs

MongoCaleb pushed a commit to MongoCaleb/docs-app-services that referenced this pull request Jun 3, 2024
@lindseymoore @MongoCaleb
DOCSP-34316 Update Role Example Descriptions (mongodb#629)
f25de8d 
* DOCSP-34316 Update Role Example Descriptions

* add info about screenshot

* fix screenshots

* fix last example

* emphasis fix

* copy fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacharyc dacharyc dacharyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindseymoore @docs-builder-bot @dacharyc