Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DOCSP-34712): Admin API Ticket Roundup: Schemas, Deployment Drafts, and List/Create Apps #643

Merged
merged 5 commits into from
Dec 4, 2023
Merged

(DOCSP-34712): Admin API Ticket Roundup: Schemas, Deployment Drafts, and List/Create Apps #643

merged 5 commits into from
Dec 4, 2023

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Dec 4, 2023 •
edited
Loading

Pull Request Info

Jira tickets:

Staged changes:

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for corresponding docs-realm updates, if any

Release Notes

  • App Services Admin API
    • Schemas
      • List Schemas: Remove schema object from documentation to match the API implementation.
      • Create a Schema: Add details about JSON escaping to avoid errors when creating a schema.
    • Deployment/Create a Deployment Draft: Correct the 200 response code to 201 to match API implementation.
    • Applications/Create a New App and Get an App: Add device-sync to the product types for the GET and POST endpoints.

Review Guidelines

REVIEWING.md

@dacharyc dacharyc merged commit a90fc85 into mongodb:master Dec 4, 2023
4 checks passed
@dacharyc dacharyc deleted the DOCSP-34712 branch December 4, 2023 22:06
@docs-builder-bot
Copy link

✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/atlas-app-services/master/

🪵 Logs

@dacharyc dacharyc changed the title (DOCSP-34712): Admin API/List Schemas: Remove schema object to match API implementation (DOCSP-34712): Admin API Ticket Roundup: Schemas, Deployment Drafts, and List/Create Apps Dec 4, 2023
MongoCaleb pushed a commit to MongoCaleb/docs-app-services that referenced this pull request Jun 3, 2024
@dacharyc @MongoCaleb
(DOCSP-34712): Admin API/List Schemas: Remove schema object to match …
f077998 
…API implementation (mongodb#643)

* Remove schema object to match API implementation

* Add note about JSON payload format escaping

* Change 200 response code to the correct 201

* Add 'device-sync' to get and create App endpoints

* Add 'device-sync' to AppInstance schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbullinger cbullinger cbullinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dacharyc @docs-builder-bot @cbullinger