Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-33212): Updating an IQF value from device causes a compensating write #646

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Dec 5, 2023

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-33212

Staged changes:

  • Sync Settings: Note that attempting to change an indexed queryable field value on device causes a compensating write error. Link to the compensating write error documentation for more information.
  • Sync Errors: Add attempting to change an indexed queryable field value to the list of conditions that can trigger a compensating write error.

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for corresponding docs-realm updates, if any

Release Notes

  • Device Sync
    • Configure Sync/Sync Settings: Note that attempting to change an indexed queryable field value on device causes a compensating write error. Link to the compensating write error documentation for more information.
    • Handle Errors/Sync Errors: Add attempting to change an indexed queryable field value to the list of conditions that can trigger a compensating write error.

Review Guidelines

REVIEWING.md

Copy link

@sean-brandenburg sean-brandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few minor tweaks on the compensating write error description

source/sync/error-handling/errors.txt Outdated Show resolved Hide resolved
Copy link

@sean-brandenburg sean-brandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link
Collaborator

@cbullinger cbullinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -138,6 +138,8 @@ The following errors may occur when your App uses :ref:`Flexible Sync
does not have write permissions to.
- Modifying an object in such a way that client would no longer have
write permissions on that object or field after the write.
- Updating an existing object's :ref:`indexed queryable field <fs-indexed-queryable-fields>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're in here, can we add periods to all of these bullets for consistency?

@dacharyc dacharyc merged commit 329dbe5 into mongodb:master Dec 6, 2023
4 checks passed
@dacharyc dacharyc deleted the DOCSP-33212 branch December 6, 2023 16:38
@docs-builder-bot
Copy link

MongoCaleb pushed a commit to MongoCaleb/docs-app-services that referenced this pull request Jun 3, 2024
…g write (mongodb#646)

* Updating an IQF value from device causes a compensating write

* Incorporate review feedback

* Add periods for consistency, add facet tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants