-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-33212): Updating an IQF value from device causes a compensating write #646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few minor tweaks on the compensating write error description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -138,6 +138,8 @@ The following errors may occur when your App uses :ref:`Flexible Sync | |||
does not have write permissions to. | |||
- Modifying an object in such a way that client would no longer have | |||
write permissions on that object or field after the write. | |||
- Updating an existing object's :ref:`indexed queryable field <fs-indexed-queryable-fields>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're in here, can we add periods to all of these bullets for consistency?
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/atlas-app-services/master/ 🪵 Logs |
…g write (mongodb#646) * Updating an IQF value from device causes a compensating write * Incorporate review feedback * Add periods for consistency, add facet tags
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-33212
Staged changes:
Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
Review Guidelines
REVIEWING.md