Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DOCSP-36150): Add callout about ignoring collation #668

Merged
merged 3 commits into from
Feb 5, 2024
Merged

(DOCSP-36150): Add callout about ignoring collation #668

merged 3 commits into from
Feb 5, 2024

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Feb 2, 2024 •
edited
Loading

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-36140

We don't have a great place to add this information. I've added it to a couple of spots where it may be relevant, but I'm open to other suggestions. I'm also on the fence about whether we should include this information in the SDKs, too.

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • programming_language
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-realm work, if any

Release Notes

  • Device Sync
    • Get Started: Add info to the "Create queries in your client application" section about Sync ignoring custom collation when evaluating subscriptions.
  • Define Data Access Permissions
    • Device Sync-Compatible Permissions: Add info about Sync ignoring custom collation when evaluating permissions.

Review Guidelines

REVIEWING.md

cbullinger
cbullinger approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@cbullinger cbullinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, otherwise lgtm!

source/includes/important-sync-ignores-custom-collation.rst Outdated Show resolved Hide resolved
@dacharyc dacharyc merged commit 70a8126 into mongodb:master Feb 5, 2024
4 checks passed
@dacharyc dacharyc deleted the DOCSP-36140 branch February 5, 2024 15:44
@docs-builder-bot
Copy link

✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/atlas-app-services/master/

🪵 Logs

MongoCaleb pushed a commit to MongoCaleb/docs-app-services that referenced this pull request Jun 3, 2024
@dacharyc @cbullinger @MongoCaleb
(DOCSP-36150): Add callout about ignoring collation (mongodb#668)
838b571 
* Add callout about ignoring collation

* Add meta descriptions and facet values

* Incorporate review feedback

Co-authored-by: cbullinger <[email protected]>

---------

Co-authored-by: cbullinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbullinger cbullinger cbullinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dacharyc @docs-builder-bot @cbullinger