Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-37062): Update Trigger config & Admin API details #864

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Oct 8, 2024

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-37062

Staging Links

Note for reviewer: it's not currently possible to view a staged version of the Admin API reference. I'll check it after deploy and fast follow to fix any errors.

  • openapi-admin-v3.yaml
  • reference/config/triggers
  • Reminder Checklist

    Before merging your PR, make sure to check a few things.

    • Did you tag pages appropriately?
      • genre
      • programming_language
      • meta.keywords
      • meta.description
    • Describe your PR's changes in the Release Notes section
    • Create a Jira ticket for related docs-realm work, if any

    Release Notes

    Review Guidelines

    REVIEWING.md

    Copy link

    netlify bot commented Oct 8, 2024

    Deploy Preview for app-services ready!

    Name Link
    🔨 Latest commit 4dcb37c
    🔍 Latest deploy log https://app.netlify.com/sites/app-services/deploys/67058181902257000865b000
    😎 Deploy Preview https://deploy-preview-864--app-services.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.
    Lighthouse
    Lighthouse
    1 paths audited
    Performance: 44 (🟢 up 20 from production)
    Accessibility: 85 (no change from production)
    Best Practices: 75 (no change from production)
    SEO: 77 (no change from production)
    PWA: -
    View the detailed breakdown and full score reports

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @cbullinger cbullinger left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm!

    source/openapi-admin-v3.yaml Outdated Show resolved Hide resolved
    - `"DROP_DATABASE"`

    For more information, refer to
    [Trigger Configuration](https://www.mongodb.com/docs/atlas/app-services/triggers/database-triggers/#configuration).
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    just confirming this should go to the /database-triggers page

    Copy link
    Collaborator Author

    @dacharyc dacharyc Oct 8, 2024

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    That was the plan, because this is specific to Database Triggers, and there is more info there. There's also info on the config reference page. But I think the main "Database Triggers" page is more likely to be actively maintained - for better or worse, we tend to forget the config reference pages exist and forget to update them.

    @dacharyc dacharyc merged commit 94a904c into mongodb:master Oct 8, 2024
    9 checks passed
    @dacharyc dacharyc deleted the DOCSP-37062 branch October 8, 2024 19:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants