-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-28193) created a page for securely storing config file #133
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @carriecwk! LGTM. Just one suggestion you can take or leave.
source/security.txt
Outdated
:depth: 1 | ||
:class: singlecol | ||
|
||
{+atlas-cli+}, like most popular CLIs, enables you to store your configuration file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{+atlas-cli+}, like most popular CLIs, enables you to store your configuration file in | |
The {+atlas-cli+}, like most popular CLIs, enables you to store your configuration file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Installing the ``platformdirs`` `Python package <https://pypi.org/project/platformdirs/>`__ to determine appropriate platform-specific directories | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really sure what to do with this, what do I do once I found the file location?
Overriding the Private API Key Value by Using an Environment Variable | ||
--------------------------------------------------------------------- | ||
|
||
You can specify configuration settings by using :ref:`environment variables <atlas-cli-env-vars>`. | ||
When you run any command, each setting that you specify with an environment variable takes precedence | ||
over the profile stored in the configuration file. | ||
|
||
You can encrypt the value of your private API key by overriding your private API key value through | ||
the :ref:`MONGODB_ATLAS_PRIVATE_API_KEY environment variable <atlas-cli-env-vars>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this guide is about storing the file location but then the first recommendation is not not use the file, I find this a bit confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this guide is a bit confusing, it doesn't really tell me how to tore the file securely, it first tells me not to use the file and use envs instead, then just tells me to change to config file location without actually telling me how to make it secure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I think mongocli docs handles this a bit better dirrectly explaning the file in a general config file page
https://www.mongodb.com/docs/mongocli/stable/configure/configuration-file/
Atlas CLI instead talks about saving connections settins, https://docs-mongodbcom-staging.corp.mongodb.com/atlas-cli/docsworker-xlarge/DOCSP-28193/atlas-cli-save-connection-settings/, which would be the last place I would look for the config file details, and it then for linux mentions XDG_CONFIG_HOME
JIRA
STAGING
BUILD