-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update url paths to include -drivers
suffix for consistency
#923
Conversation
raw: docs/drivers/drivers/pymongo/ -> ${base}/pymongo/ | ||
raw: docs/drivers/drivers/ruby/ -> https://www.mongodb.com/docs/ruby-driver/current/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first item in the Ruby dropdown menu links to this site.
raw: docs/drivers/drivers/php/ -> ${base}/php-drivers/ | ||
raw: docs/drivers/drivers/python/ -> ${base}/python-drivers/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccho-mongodb These redirects don't seem to be working. In staging, I still see the old page, which now no longer shows the correct navbar entries. Do these redirects only take effect after deployment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redirects aren't written to the staging environment, only the production environment. To build confidence that they will work in production, we usually generate the redirects output with mut-redirects, and paste that into the PR. Then, we test them in production once deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachel-mack The steps for creating redirects are here. Can you follow the steps under Running Tests for Redirects and paste the output into the PR so we can test those links?
Here's a diff of mut-redirects output (full txt files attached for reference):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good -- I think some redirects are missing because of missing colons. Could you update that and the redirect output diff? Once completed, please ask for a re-review. Thanks!
new diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let me know if you want to pair on checking that the published version works as intended.
2f59448
to
1b33af0
Compare
1b33af0
to
aed039f
Compare
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-30932
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-xlarge/DOCSP-30932/
Self-Review Checklist
Did you run a spell-check?Did you run a grammar-check?