-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ecosystem] Clean unused files from docs-ecosystem repository #935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file still appears to exist in staging, even tho it doesn't exist in the index TOC. I've tried clearing my cache, but it's still there.
https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-xlarge/DOCSP-29854/specs/
Also, this file accessible by searching for the the title from the docs website, even though it's not in the index. So I'm not sure if I should remove it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
I agree with the assessment to remove it. Regarding the staging copy, I think it could be helpful to report this publishing issue as a JIRA ticket in the DOP project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, noted one issue to resolve before merging and publishing.
Questions:
Were there any other files in the list that were kept? Were there any common themes among those files? I think this info could help improve the docdoctor module.
@@ -1,19 +0,0 @@ | |||
:orphan: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue:
I think this page was left intentionally as shown by the "orphan" directive. I'm guessing this may have been for SEO reasons since it shows up in a Google search.
Suggestion:
I think the quickest solution could be to keep this file.
Another solution, which could take more time, could be to incorporate the content into https://www.mongodb.com/docs/drivers/about-compatibility/ and then create a redirect from this page to that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
I agree with the assessment to remove it. Regarding the staging copy, I think it could be helpful to report this publishing issue as a JIRA ticket in the DOP project.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-29854
Staging - https://docs-mongodborg-staging.corp.mongodb.com/drivers/docsworker-xlarge/DOCSP-29854/
Self-Review Checklist
[ ] Did you run a spell-check?[ ] Did you run a grammar-check?[ ] Are the [facets and meta keywords](https://wiki.corp.mongodb.com/display/DE/Docs+Taxonomy) accurate?