Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecosystem] Clean unused files from docs-ecosystem repository #935

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

rachel-mack
Copy link
Contributor

@rachel-mack rachel-mack commented Nov 23, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-29854
Staging - https://docs-mongodborg-staging.corp.mongodb.com/drivers/docsworker-xlarge/DOCSP-29854/

Self-Review Checklist

Copy link
Contributor Author

@rachel-mack rachel-mack Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file still appears to exist in staging, even tho it doesn't exist in the index TOC. I've tried clearing my cache, but it's still there.
https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-xlarge/DOCSP-29854/specs/

Also, this file accessible by searching for the the title from the docs website, even though it's not in the index. So I'm not sure if I should remove it or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

I agree with the assessment to remove it. Regarding the staging copy, I think it could be helpful to report this publishing issue as a JIRA ticket in the DOP project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachel-mack rachel-mack marked this pull request as ready for review November 23, 2023 17:19
Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noted one issue to resolve before merging and publishing.

Questions:
Were there any other files in the list that were kept? Were there any common themes among those files? I think this info could help improve the docdoctor module.

@@ -1,19 +0,0 @@
:orphan:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue:

I think this page was left intentionally as shown by the "orphan" directive. I'm guessing this may have been for SEO reasons since it shows up in a Google search.

Suggestion:

I think the quickest solution could be to keep this file.
Another solution, which could take more time, could be to incorporate the content into https://www.mongodb.com/docs/drivers/about-compatibility/ and then create a redirect from this page to that one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

I agree with the assessment to remove it. Regarding the staging copy, I think it could be helpful to report this publishing issue as a JIRA ticket in the DOP project.

@rachel-mack rachel-mack merged commit e2d8f25 into mongodb:master Nov 28, 2023
1 check passed
@rachel-mack rachel-mack deleted the DOCSP-29854 branch November 28, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants