Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-4466 Add CSOT #951

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

DOCSP-4466 Add CSOT #951

wants to merge 16 commits into from

Conversation

stephmarie17
Copy link
Collaborator

@stephmarie17 stephmarie17 commented Dec 13, 2024 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44666
Staging - https://deploy-preview-951--docs-node.netlify.app/fundamentals/connection/csot/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2024 •
edited
Loading

✅ Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 06a08d7
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/6785a0d8b84e1a000854dd69
😎 Deploy Preview https://deploy-preview-951--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephmarie17 stephmarie17 marked this pull request as ready for review December 18, 2024 17:25
lindseymoore
lindseymoore requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, thanks for taking this! Some suggestions for clarity and small fixes. I'll be back Jan 7, but Mike says he is available for re-review if you want it back a little sooner. Have a great holiday break!

source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/code-snippets/connection/csot.js Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
mongoKart
mongoKart requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of comments, but they're all small. great work!

source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
@stephmarie17 stephmarie17 requested a review from mongoKart January 6, 2025 22:03
mongoKart
mongoKart approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple small things but otherwise LGTM

source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
lindseymoore
lindseymoore approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments and fix, great work on this! LGTM :)

source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
source/fundamentals/connection/csot.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mongoKart mongoKart mongoKart approved these changes

@lindseymoore lindseymoore lindseymoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephmarie17 @lindseymoore @mongoKart