-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-46230: atlas search index mgmt #3270
DOCSP-46230: atlas search index mgmt #3270
Conversation
fed5cb5
to
77d77f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some ordered lists:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code sample would be better in a unit test, otherwise SGTM.
use Illuminate\Support\Facades\Schema; | ||
use MongoDB\Laravel\Schema\Blueprint; | ||
|
||
return new class extends Migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the migration class is not actually displayed in the docs, you can move code snippets in up
and down
methods into unit tests that would validate them (ensure the index is correctly created) and deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
https://jira.mongodb.org/browse/DOCSP-46230
document how to create search and vs indexes with the Schema builder
STAGING:
Checklist