Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-44554: add more aggregation examples #3272

Merged
merged 7 commits into from
Feb 25, 2025

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Feb 12, 2025

https://jira.mongodb.org/browse/DOCSP-44554

Adds more examples of using the aggregation builder

STAGING

Checklist

  • Add tests and ensure they pass

@rustagir rustagir requested a review from a team as a code owner February 12, 2025 15:27
@rustagir rustagir requested a review from norareidy February 12, 2025 15:27
@github-actions github-actions bot added the docs label Feb 12, 2025
@rustagir rustagir force-pushed the DOCSP-44554-agg-builder-examples branch from ca9cc96 to 2de60ea Compare February 12, 2025 15:36
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 w/ 2 small comments

@rustagir rustagir requested a review from GromNaN February 12, 2025 17:57
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good choice of examples.
I think the text is no longer correct.

Comment on lines +162 to +163
Query::gte(new UTCDateTime(new DateTimeImmutable('2014-01-01'))),
Query::lt(new UTCDateTime(new DateTimeImmutable('2015-01-01'))),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could skip the new UTCDateTime part, but that's not possible due to type restrictions. https://jira.mongodb.org/browse/PHPLIB-1634

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When that ticket is resolved, we can always make the updates to the docs!

@rustagir rustagir requested a review from GromNaN February 25, 2025 15:45
@rustagir rustagir merged commit f10f346 into mongodb:5.1 Feb 25, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants