-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-44554: add more aggregation examples #3272
DOCSP-44554: add more aggregation examples #3272
Conversation
ca9cc96
to
2de60ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 w/ 2 small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good choice of examples.
I think the text is no longer correct.
Query::gte(new UTCDateTime(new DateTimeImmutable('2014-01-01'))), | ||
Query::lt(new UTCDateTime(new DateTimeImmutable('2015-01-01'))), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we could skip the new UTCDateTime
part, but that's not possible due to type restrictions. https://jira.mongodb.org/browse/PHPLIB-1634
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When that ticket is resolved, we can always make the updates to the docs!
https://jira.mongodb.org/browse/DOCSP-44554
Adds more examples of using the aggregation builder
STAGING
Checklist