Skip to content

DOCSP-38130: Time series collections #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 21, 2025

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Feb 12, 2025

@norareidy norareidy requested a review from a team as a code owner February 12, 2025 19:38
@norareidy norareidy requested a review from rustagir February 12, 2025 19:38
@github-actions github-actions bot added the docs label Feb 12, 2025
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@norareidy norareidy requested a review from GromNaN February 12, 2025 20:21
->insert($data);
// end time series

$this->assertIsBool($result);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->assertIsBool($result);
$this->assertTrue($result);

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@norareidy norareidy merged commit f62046d into mongodb:5.1 Feb 21, 2025
27 checks passed
@norareidy norareidy deleted the DOCSP-38130-time-series branch February 21, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants