Include the compiler variant in Windows release file names for PHP 8.3 #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Oct 11, 2024
| @@ -120,7 +120,7 @@ jobs: | |||
| "7.4") | |||
| COMPILER="vc15" | |||
| ;; | |||
| "8.0" | "8.1" | "8.2") | |||
| "8.0" | "8.1" | "8.2" | "8.3") | |||
|
@mickverm: The change here should apply with the next 1.x release. In the meantime, I manually renamed the 8.3 release artifacts in the 1.20.0 release if you'd like to try again. |
|
Opened #1718 to rebase this on v1.20, as I couldn't figure out how to modify the PR branch directly (and merely changing the base won't do). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1716