Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-280230: Refactor adds Project Dual Reference #1971

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Dec 5, 2024

While the refactor change accept many files, there are only a few key places that are key:

  • The new ProjectDualReference at pkg/api/v1/projectref.go encapsulates together the 3 fields that are required for all CRDs that depend on a project and have dual mode of operation with independent IDs and Kubernetes references.
  • The credentials types at pkg/api/credentials.go are simplifies all types but CredentialsProvider interface disappear and a new ObjectwithCredentials allows indexers to define kubertenes objects that carry credentials, such is the case of these dual references.
  • All CRDs supporting independent usage are changed to use the new ProjectDualReference.

All the rest of changes are derived from there:

  • Some CRD descriptions are changes to become consistent under config/crd/bases. There are no changes to the YAML, this is a refactor.
  • Some reference namings are corrected to be consistent across all types now.
  • All tests need to be fixed with the new type shape, fields are moved around, and sometimes renamed.

This PR contains 5 commits, the new code infrastructure and 4 more for each type migrated to use it, db users, custom roles, private endpoints and deployments.

All Submissions:

  • Have you signed our CLA?

All Submissions:

  • Have you signed our CLA?

@josvazg josvazg requested review from helderjs, igor-karpukhin, cveticm and s-urbaniak and removed request for helderjs and igor-karpukhin December 5, 2024 14:17
@josvazg josvazg changed the title Refactor adds Project Dual Reference CLOUDP-280230: Refactor adds Project Dual Reference Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants