Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-284792: Remove services from reconcilers #2025

Merged
merged 4 commits into from
Jan 13, 2025
Merged

CLOUDP-284792: Remove services from reconcilers #2025

merged 4 commits into from
Jan 13, 2025

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Jan 8, 2025

All Submissions:

  • Have you signed our CLA?

@josvazg josvazg marked this pull request as draft January 8, 2025 08:26
@josvazg josvazg mentioned this pull request Jan 9, 2025
Merged
3 tasks
@josvazg josvazg force-pushed the CLOUDP-280230/add-project-refs branch from 0fad38d to 71e4e49 Compare January 10, 2025 15:45
Base automatically changed from CLOUDP-280230/add-project-refs to main January 10, 2025 17:35
@josvazg josvazg force-pushed the CLOUDP-284792/no-services-at-reconcicler branch from 7f7a403 to bcda48b Compare January 12, 2025 09:31
@josvazg josvazg marked this pull request as ready for review January 12, 2025 09:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/4a47f0fd289c9b7f83908b3d7dff2137b10199f5

s-urbaniak
s-urbaniak approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josvazg josvazg merged commit 15aa149 into main Jan 13, 2025
57 checks passed
@josvazg josvazg deleted the CLOUDP-284792/no-services-at-reconcicler branch January 13, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@helderjs helderjs helderjs approved these changes

@igor-karpukhin igor-karpukhin Awaiting requested review from igor-karpukhin

@roothorp roothorp Awaiting requested review from roothorp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josvazg @helderjs @s-urbaniak