-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-293822: Fix targets affected by new project layout #2028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@helderjs Looks good, but I think the "scripts/deploy.sh" also has to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, so far, just holding in case more changes are also needed as mentioned by @igor-karpukhin
@helderjs one more place I found is here:
|
Does this mean we have been failing to generate/update some things since we changed the project structure? |
Probably, but the PR was merged Monday, so previous deliveries were not affected. |
Oh, for some reason I thought we'd made this change earlier than that! In that case LGTM. |
All Submissions:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if there is one).