CLOUDP-294932: Fix contract test skips #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
requested review from
helderjs,
s-urbaniak,
igor-karpukhin and
roothorp
josvazg
changed the title
josvazg
force-pushed
the
CLOUDP-294932/fix-contract-skips
branch
from
7ed2616 to
8f6fa5b
Compare
helderjs
approved these changes
Jan 15, 2025
test/helper/contract/contract.go
Outdated
| @@ -68,6 +61,16 @@ func RunGoContractTest(ctx context.Context, t *testing.T, name string, contractT | |||
| }) | |||
| } | |||
|
|
|||
| func skipCheck(name, focus string, enabled bool) string { | |||
There was a problem hiding this comment.
Wouldn't (bool, string) or simply error be a more idiomatic type return?
There was a problem hiding this comment.
yes, error seems better
Signed-off-by: jose.vazquez <[email protected]>
josvazg
force-pushed
the
CLOUDP-294932/fix-contract-skips
branch
from
8f6fa5b to
cac9bcd
Compare
s-urbaniak
reviewed
Jan 16, 2025
Use simpler non parameterised error constructor Co-authored-by: Sergiusz Urbaniak <[email protected]>
Signed-off-by: jose.vazquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug skipping all contract tests by default and add unit tests to verify fix.
All Submissions: