Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-280230: Fix network peering old tests settings #2069

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Jan 24, 2025

Order and clean up the test fields to reflect proper usage of the CRD API:

  • Remove RouteTableCIDRBlock from the GCP test, as it is not used by GCP.
  • Remove AccepterRegionName from GCP test, as it is has no effect in GCP.
  • Replace AccepterRegionName with ContainerRegion in the Azure test. Even though accepter region acts as a fallback value when container region is not set, it is more correct to use the actual container region field, specially since the accepter region name is an AWS only concept in the API.
  • Order the setting fields in all tests to clarify which ones refer to the container configuration and which others affect the peering connection on the app/client side.

All Submissions:

  • Have you signed our CLA?

Copy link
Contributor

github-actions bot commented Jan 24, 2025

@josvazg josvazg merged commit 587162e into main Jan 29, 2025
58 checks passed
@josvazg josvazg deleted the CLOUDP-280230/fix-net-peering-old-tests branch January 29, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants