Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-280230: Refactor dual ref CEL validations #2071

Merged
merged 1 commit into from
Jan 29, 2025
Merged

CLOUDP-280230: Refactor dual ref CEL validations #2071

merged 1 commit into from
Jan 29, 2025

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Jan 27, 2025 •
edited
Loading

Group all dual references CEL tests in a single test battery.

Related to works on CLOUDP-280230 Network peering CRD support

All Submissions:

  • Have you signed our CLA?

s-urbaniak
s-urbaniak requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: this is missing a ticket

@josvazg josvazg changed the title Refactor dual ref CEL validations CLOUDP-280230: Refactor dual ref CEL validations Jan 27, 2025
@josvazg
Copy link
Collaborator Author

josvazg commented Jan 27, 2025

CLOUDP-280230

@josvazg josvazg force-pushed the CLOUDP-280230/fix-dual-ref-cel-tests branch from 11d5242 to e0db8ff Compare January 29, 2025 09:11
s-urbaniak
s-urbaniak approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit which I encourage fix as it makes the code smaller.

@josvazg josvazg force-pushed the CLOUDP-280230/fix-dual-ref-cel-tests branch from e0db8ff to 3a83c39 Compare January 29, 2025 12:45
@josvazg josvazg merged commit 19f1e99 into main Jan 29, 2025
9 checks passed
@josvazg josvazg deleted the CLOUDP-280230/fix-dual-ref-cel-tests branch January 29, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helderjs helderjs helderjs approved these changes

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@roothorp roothorp roothorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josvazg @helderjs @s-urbaniak @igor-karpukhin @roothorp