Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-296898: use errors for termination #2072

Merged
merged 1 commit into from
Jan 27, 2025
Merged

CLOUDP-296898: use errors for termination #2072

merged 1 commit into from
Jan 27, 2025

Conversation

s-urbaniak
Copy link
Collaborator

For dry-run we need to be able to notify about errors during dry-run reconciliation. These can be various failure modes like:

  • Atlas API not reachable (5xx)
  • Connection secrets not being configured correctly
  • internal errors

Currently, there is no way to distinguish reconcile results from failure results. This fixes it by adding errors vs. strings to our Terminate* methods. Dry-run is going to read out this error, skip on the the internal dry-run errors, and report everything else as an event.

Note: this is also a good intermediate for future optimisation of error return handling in conjunction with idiomatic controller-runtime error handling.

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

@s-urbaniak s-urbaniak merged commit 445b06a into main Jan 27, 2025
58 checks passed
@s-urbaniak s-urbaniak deleted the CLOUDP-296898 branch January 27, 2025 11:11
@josvazg
Copy link
Collaborator

josvazg commented Jan 27, 2025

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants