MONGOID-5674 [Monkey Patch Removal] Remove Object#regexp? #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
johnnyshields
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MONGOID-5674
Object#regexp? is a trivial kernel monkey patch which returns true for Regexp and BSON::Regexp::Raw, and false for all else, including BSON::Regexp.
Because it is used by other monkey patch methods (on String) which cannot be easily removed, for now I have moved it to a private monkey patch
String#__regexp?(object). This will be a stepping stone to further refactoring. I've also added additional tests for the two methods on String where it is used (the BSON::Regexp::Raw case was missing.) No tests are added for any private methods.Overall progress is tracked here: http://tinyurl.com/mongoid-monkey. Refer to MONGOID-5660 for context.