updated Mongoid to v. 6 #231
Conversation
| @@ -1,5 +1,6 @@ | |||
| ## 5.3.1 (Next) | |||
|
|
|||
| * Upgraded mongoid to 6.0.0 - [@moodlemags](https://github.com/moodlemags). | |||
There was a problem hiding this comment.
Change this to [#231](...): Compatibility with Mongoid 6 - [...]().
|
Looks good. Amend the changelog with the pull request number please and try to squash your commits (good exercise). |
|
Code looks good, but you still need to add mongoid 6 to https://github.com/mongoid/mongoid-slug/blob/master/.travis.yml, which is the CI so it actually runs tests against 6.0. |
|
Bump @moodlemags. See my comment above. |
|
Squash your commits as well to make this a single commit with a nice the description. |
|
Hi, @dblock you can squash PR commits on accepting it with squash commits option |
|
@Fudoshiki Thanks. I was helping @moodlemags IRL make her first (second) open-source PR, while github lets you squash commits it's good practice. Anyone wants to finish this? |
|
@dblock Oh my gosh! I got so focused on the other one this one slipped past. I am on it! |
|
@dblock umm so I seem to have accidentally rebased everything and have been trying to undo it and cannot. Is it possible? I'm considering making just a new branch and doing from that. Eek! |
|
New branch can work too, feel free to close this and reopen a new PR. Or you can force push over your other branch. |
|
Alright! Now the build is failing for a legit reason, see https://travis-ci.org/mongoid/mongoid-slug/jobs/168612055. |
|
it is sneaky! I have found where just figuring out the how to fix now |
|
It's probably missing the paranoia gem for mongoid 6. It used to be part of mongoid and was moved into being an external dependency around version 4. |
| when 'HEAD' | ||
| gem 'mongoid', github: 'mongodb/mongoid' | ||
| gem 'mongoid_paranoia', github: 'simi/mongoid_paranoia' | ||
| gem 'mongoid-observers' | ||
| gem 'rails-observers', github: 'rails/rails-observers' | ||
| when /^6/ | ||
| gem 'mongoid', '~> 6.0.0' |
There was a problem hiding this comment.
add this here
gem 'mongoid_paranoia', github: 'simi/mongoid_paranoia'
gem 'mongoid-observers'
gem 'rails-observers', github: 'rails/rails-observers'There was a problem hiding this comment.
@Fudoshiki feel free to finish this up in a separate PR!
|
Thanks for the nice work everyone! What is missing to support mongoid 6 ? |
|
@marceloboeira Just a passing build here! Feel free to take over. |
|
Ignore me, just taking this over, #234. |
|
@marceloboeira notice that the gem as released works, there were no code changes |
|
@dblock yeap, I am using here, but I will sleep better knowing that the build is green for mongoid 6.x 👍 |
No description provided.