Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Lower refresh_interval default from 300 to 10 sec #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisckchang
Copy link

Current default is too high- if a failover occurs, an existing connection won't detect a new PRIMARY for potentially up to 300 seconds.

I propose changing the default to 10 or 5 seconds. See Durran's code here for reference:
https://github.com/mongodb/mongo-ruby-driver/blob/89733bc5cfab5b82228d663c285135f2deea6cd0/lib/mongo/server/monitor.rb#L28-L58

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 6b744eb on chrischang12:master into 2d92a6b on mongoid:master.

@chrisckchang
Copy link
Author

i'd be happy to provide a test that demonstrates the behavior, let me know if that's necessary

@arthurnn
Copy link
Contributor

That might make sense , however we probably will need a major/minor release for this change.

@arthurnn arthurnn added this to the 2.1.0 milestone Jul 31, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants