Add Ruby 3.4 to CI matrix #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the mongo gem depends on the base64 gem, which has been extracted as a bundled gem since Ruby 3.4. Let's install the base64 gem only for test.
the activesupport gem depends on the base64 gem, which has been extracted as a bundled gem since Ruby 3.4. Let's install the base64 gem only for test.
|
@smtlaissezfaire Note that we don't need to release a new plucky version to support Ruby 3.4. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds Ruby 3.4 to the CI matrix.
We don't need to update the implementation for Ruby 3.4.
Ruby 3.4 Release Note:
https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-0-released/
Notes
The mongo gem hasn't released a version that supports Ruby 3.4 officially
mongo v2.22.0 would support Ruby 3.4, but it will take more time until it is released.
However, the latest version should work.
mongodb/mongo-ruby-driver#2923
Developers who use Ruby 3.4 may need to add the some gems for implicit dependencies
Ruby 3.4 has extracted some bundled gems. plucky depends on the following ones indirectly.
I've added them to Gemfile only to pass the tests.
Developers can also fix dependency errors by adding missing gems to their Gemfile themselves.
Related