Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update langs and monica:localize command. Add 3 new languages. #6917

Merged
merged 25 commits into from
Oct 9, 2023
Merged

feat: update langs and monica:localize command. Add 3 new languages. #6917

merged 25 commits into from
Oct 9, 2023

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Oct 6, 2023 •
edited
Loading

This also adds ar, pt-BR and zh-TW translations

@asbiin asbiin requested a review from djaiss October 6, 2023 21:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

5.2% 5.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

djaiss
djaiss approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR.
Great job.

@asbiin asbiin changed the title feat: update langs feat: update langs and monica:localize command. Add 3 new languages. Oct 9, 2023
@asbiin asbiin merged commit 2fe7abc into main Oct 9, 2023
14 of 15 checks passed
@asbiin asbiin deleted the 20231006-lang branch October 9, 2023 20:42
@github-actions
Copy link

🎉 This PR is included in version 5.0.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asbiin @djaiss