Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe typing doesn't highlight completed words well #5624

Open
2 tasks done
asasine opened this issue Jul 17, 2024 · 2 comments
Open
2 tasks done

Swipe typing doesn't highlight completed words well #5624

asasine opened this issue Jul 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@asasine
Copy link
Contributor

asasine commented Jul 17, 2024

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

No response

Account config

No response

Current Behavior

When swipe typing, words are accepted with correct accuracy, and the cursor advances to the next word, but after the first word, the previous word is duplicated as both complete (colored dark) and incomplete (colored light), with the cursor between the two. This video should clarify.

monkeytype.swipe.typing.bug.MP4

Additionally, if the doubled word happens to end the current line, the doubled word takes up the "slot" where the next word should be. You can see this occur around 26s into the video with the word increase. There's no way to know what the next word is.

Expected Behavior

The duplicate word shouldn't appear. The next word should remain visible when at the end of the final line.

Steps To Reproduce

  1. Ensure swipe typing is enabled on iOS (General > Keyboard > Slide to Type)
  2. Go to monkeytype.com in Safari
  3. Swipe type a test

Environment

  • OS: iOS 17.5.1
  • Browser: Safari
  • Browser Version: I think it's synced with the iOS version but the user agent is Mozilla/5.0 (iPhone; CPU iPhone OS 17_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Mobile/15E148 Safari/604.1

Anything else?

No response

@asasine asasine added the bug Something isn't working label Jul 17, 2024
@Reyan9450
Copy link

I think this is happening because the monkey type is not configured to handle swipe typing, and I tried to look in the codebase but could not find the file that handles keyboard events if anyone knows which file handles the keyboard events please let me know.

@Miodec
Copy link
Member

Miodec commented Jul 25, 2024

Swipe typing will work but some changes have been made in the way input is displayed.

@Reyan9450 input-controller.ts:1373 should be the place where swipe is handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants