Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swipe typing duplicate word issue fixed (@HemendraSinghShekhawat) #6018

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HemendraSinghShekhawat
Copy link

@HemendraSinghShekhawat HemendraSinghShekhawat commented Nov 7, 2024

Description

fixed: swipe type duplication error fixed for English.
NOTE: (not checked on another languages, don't know if that is even possible)
Asked ChatGPT on how to create a PR : ) (thanks for monkeytype btw)

related issue: #5624

Swipe type video on local:

monkey-type-swipe-type.mp4

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Nov 7, 2024
@HemendraSinghShekhawat
Copy link
Author

Any suggestions, as this is my first PR.

@Miodec
Copy link
Member

Miodec commented Nov 8, 2024

How are you testing swipe typing on a desktop machine?

@HemendraSinghShekhawat
Copy link
Author

Well i am using windows, and there is a on screen keyboard available for it, and it supports swipetyping
The keyboard is available on taskbar bottom right
image

if it is not turned on, it is available under settings -> Time and Language -> Typing -> Touch keyboard -> show the touch keyboard => Always(change dropdown to always), then it will be available on taskbar.

image
image

also change keyboard layout to small in keyboard settings
image

Also to mention I have also tested it on my android, using chrome debug tools. I seems to work fine

@Miodec Miodec added the waiting for review Pull requests that require a review before continuing label Nov 14, 2024
Copy link

@liamstamper liamstamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, code is concise and well commented. Meets applicable checks.

Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff Stale Has not been updated in a while waiting for review Pull requests that require a review before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants