-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pen as device type and pressure for iOS touch events #1980
base: main
Are you sure you want to change the base?
Conversation
9f8480c
to
0803ef6
Compare
@richirisu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Description of Change
As mentioned in #1191 (comment), add device type support for pen touch events on iOS. Android and UWP are already implemented appropriately.
Bugs Fixed
API Changes
None
Behavioral Changes
The Apple Pencil will now be correctly recognized as pen device type. In addition, the pressure value will also be propagated to the touch event.
Although there is no change in terms of method signatures, I want to point out that the default iOS implementation for pressure reports a value of 0 when the current touch has no pressure information. Before the change it was a fixed value of 1. In my opinion, this also goes along with the Android definition that reads that the value for pressure ranges from 0 (no pressure at all) to 1 (normal pressure). iOS also defines "normal pressure" as 1, but may also very well go beyond for stronger pressure.
PR Checklist