Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add framework for reading wrapper methods from configuration. Move th… #20

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

prasad-okahu
Copy link
Contributor

…e out of box wrapper methods into config files

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • [X ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • X[ ] I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Handle wrap methods to be read from files. Move out of box support for langchain, llamaindex and haystack methods to json files. This will enable contributors to add new methods easily to monocle. Also it lays out foundation to enable new methods tracing for applications overloading the out of box methods.

prasad-okahu and others added 3 commits July 26, 2024 02:25
…e out of box wrapper methods into config files

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>
@prasad-okahu prasad-okahu force-pushed the config_tracemethod.prasad branch from 19b8559 to c7cd040 Compare July 26, 2024 02:26
@prasad-okahu prasad-okahu merged commit bf249eb into monocle2ai:main Jul 26, 2024
5 checks passed
@prasad-okahu prasad-okahu deleted the config_tracemethod.prasad branch July 26, 2024 18:40
kshitiz-okahu pushed a commit that referenced this pull request Aug 12, 2024
#20)

* Add framework for reading wrapper methods from configuration. Move the out of box wrapper methods into config files

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>

* fixed haystack method name typo

Signed-off-by: prasad-okahu <[email protected]>

* Updated the wrapper method format

Signed-off-by: prasad-okahu <[email protected]>

---------

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
kshitiz-okahu pushed a commit that referenced this pull request Aug 12, 2024
#20)

* Add framework for reading wrapper methods from configuration. Move the out of box wrapper methods into config files

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>

* fixed haystack method name typo

Signed-off-by: prasad-okahu <[email protected]>

* Updated the wrapper method format

Signed-off-by: prasad-okahu <[email protected]>

---------

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants