Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added attributes for azure infra components #23

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

kshitiz-okahu
Copy link
Contributor

@kshitiz-okahu kshitiz-okahu commented Aug 8, 2024

Proposed changes

Added the support for adding attributes for Azure infra services.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
@kshitiz-okahu kshitiz-okahu requested review from oi-raanne, prasad-okahu and anshul7665 and removed request for oi-raanne and prasad-okahu August 8, 2024 04:04
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
src/monocle_apptrace/constants.py Show resolved Hide resolved
src/monocle_apptrace/constants.py Outdated Show resolved Hide resolved
prasad-okahu and others added 2 commits August 12, 2024 10:38
#20)

* Add framework for reading wrapper methods from configuration. Move the out of box wrapper methods into config files

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>

* fixed haystack method name typo

Signed-off-by: prasad-okahu <[email protected]>

* Updated the wrapper method format

Signed-off-by: prasad-okahu <[email protected]>

---------

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
src/monocle_apptrace/constants.py Outdated Show resolved Hide resolved
@kshitiz-okahu kshitiz-okahu merged commit fde3add into main Aug 12, 2024
6 checks passed
@kshitiz-okahu kshitiz-okahu deleted the kshitiz/infra_azure_component branch November 13, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants