-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing all pylint errors with zero errors and add some rules to ignore list #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
oi-raanne
approved these changes
Aug 8, 2024
oi-raanne
reviewed
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does pylint checks run automatically before merge ?
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
oi-raanne
approved these changes
Aug 8, 2024
#20) * Add framework for reading wrapper methods from configuration. Move the out of box wrapper methods into config files Signed-off-by: Prasad Mujumdar <[email protected]> Signed-off-by: prasad-okahu <[email protected]> * fixed haystack method name typo Signed-off-by: prasad-okahu <[email protected]> * Updated the wrapper method format Signed-off-by: prasad-okahu <[email protected]> --------- Signed-off-by: Prasad Mujumdar <[email protected]> Signed-off-by: prasad-okahu <[email protected]> Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
* #17 - Add file exporter support Signed-off-by: Prasad Mujumdar <[email protected]> * Added test Signed-off-by: Prasad Mujumdar <[email protected]> * Updated docs Signed-off-by: Prasad Mujumdar <[email protected]> * Added workflow name to default file name Signed-off-by: Prasad Mujumdar <[email protected]> * Updated tests per review feedback Signed-off-by: Prasad Mujumdar <[email protected]> --------- Signed-off-by: Prasad Mujumdar <[email protected]> Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In this PR all the pylint errors have been fixed and few rules have been added to ignore
Types of changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...