Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing all pylint errors with zero errors and add some rules to ignore list #24

Closed
wants to merge 24 commits into from

Conversation

kshitiz-okahu
Copy link
Contributor

Proposed changes

In this PR all the pylint errors have been fixed and few rules have been added to ignore

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Copy link
Contributor

@oi-raanne oi-raanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does pylint checks run automatically before merge ?

Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
prasad-okahu and others added 20 commits August 12, 2024 10:30
#20)

* Add framework for reading wrapper methods from configuration. Move the out of box wrapper methods into config files

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>

* fixed haystack method name typo

Signed-off-by: prasad-okahu <[email protected]>

* Updated the wrapper method format

Signed-off-by: prasad-okahu <[email protected]>

---------

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: prasad-okahu <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
* #17 - Add file exporter support

Signed-off-by: Prasad Mujumdar <[email protected]>

* Added test

Signed-off-by: Prasad Mujumdar <[email protected]>

* Updated docs

Signed-off-by: Prasad Mujumdar <[email protected]>

* Added workflow name to default file name

Signed-off-by: Prasad Mujumdar <[email protected]>

* Updated tests per review feedback

Signed-off-by: Prasad Mujumdar <[email protected]>

---------

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants