Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception in span wrappers #52

Merged

Conversation

kshitiz-okahu
Copy link
Contributor

@kshitiz-okahu kshitiz-okahu commented Oct 16, 2024

Proposed changes

If the LLM throws an error, the return value could be null.
The code was throwing exception. This PR prevents the exception.

Also added try except to prevent any exception from monocle code.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
@oi-raanne oi-raanne closed this Oct 16, 2024
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
@kshitiz-okahu kshitiz-okahu reopened this Oct 17, 2024
@oi-raanne oi-raanne merged commit 086b223 into monocle2ai:main Oct 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants