Add monocle version changes and fix tests #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
…itiz/update_test
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
|
add span.type in workflow span |
oi-raanne
approved these changes
Oct 28, 2024
oi-raanne
requested changes
Oct 28, 2024
| @@ -4,12 +4,10 @@ name: Tox | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ "main" ] | |||
| branches: [ "main", "kshitiz/update_test" ] | |||
There was a problem hiding this comment.
pls revert this to main
There was a problem hiding this comment.
yes, just fixing the last failing test
oi-raanne
approved these changes
Oct 28, 2024
oi-raanne
requested changes
Oct 30, 2024
src/monocle_apptrace/wrap_common.py
Outdated
|
|
||
| try: | ||
| sdk_version = version("monocle_apptrace") | ||
| span.set_attribute("monocle_sdk_version",sdk_version) |
There was a problem hiding this comment.
can the attribute be monocle-apptrace.version to reflect the package name
as in https://pypi.org/project/monocle-apptrace/0.1.1/
…itiz/update_test
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added monocle version in span
Fix tests
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...