Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOBILE-4676: Use core strings #4243

Closed
wants to merge 3 commits into from
Closed

MOBILE-4676: Use core strings #4243

wants to merge 3 commits into from

Conversation

jleyva
Copy link
Contributor

@jleyva jleyva commented Nov 20, 2024

No description provided.

crazyserver
crazyserver requested changes Nov 25, 2024
View reviewed changes
scripts/langindex.json Outdated Show resolved Hide resolved
scripts/langindex.json Outdated Show resolved Hide resolved
@crazyserver
Copy link
Member

Additional to that, please change strings on lang.json from
addon.block_myoverview.nocoursesenrolled to 'You are currently not enrolled in any courses.'
addon.mod_glossary.searchquery to 'Enter your search query'
addon.messages.type_blocked to 'Blocked users'

I think the other ones do not change

@jleyva
Copy link
Contributor Author

jleyva commented Nov 26, 2024

i

@crazyserver I just applied the requested changes

@crazyserver
Copy link
Member

Closed in favour of #4248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazyserver crazyserver crazyserver requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleyva @crazyserver