Update Substrate PalletXCM and Send XC-20s Overview #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themacexpert
added
the
A1 - Maintenance Major
themacexpert
changed the title
Closed
|
@themacexpert let me know when this is ready to be reviewed :) |
albertov19
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Looking good - Left some feedback.
I think we have to also simplify a bit the explaining and just get to points a bit more direct. I reflect back on when we wrote this page and we did a lot of explaining. Let's leave the explaining around XCM more to the XCM overview page or something like that
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
|
This is ready for another review :) @albertov19 @eshaben |
Was just discussing this with Ibra last week. We could definitely benefit from scaling back on some of these pages and making them more concise. |
eshaben
reviewed
Feb 4, 2025
...ets/text/builders/interoperability/xcm/xc20/send-xc20s/overview/xcDOT-to-DOT-instructions.md
Outdated
Show resolved
Hide resolved
...ets/text/builders/interoperability/xcm/xc20/send-xc20s/overview/DOT-to-xcDOT-instructions.md
Outdated
Show resolved
Hide resolved
albertov19
requested changes
Feb 4, 2025
Co-authored-by: Erin Shaben <[email protected]>
…verview/xcDOT-to-DOT-instructions.md Co-authored-by: Erin Shaben <[email protected]>
…verview/DOT-to-xcDOT-instructions.md Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
albertov19
requested changes
Feb 7, 2025
builders/interoperability/xcm/core-concepts/sovereign-accounts.md
Outdated
Show resolved
Hide resolved
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
albertov19
approved these changes
Feb 7, 2025
themacexpert
added
B1 - Ready to be Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Corresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
Items to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.