Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kusama fees to v1.0.0 and rollback polkadot links to v0.9.43 #792

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Nov 16, 2023

Description

This PR updates the fees page for Kusama v1.0.0 and reverts the Polkadot links back to the deprecated repo where v0.9.43 was released. As announced in the v1.0.0 release notes, all runtime code has been moved to the fellowship PR, so this impacts the benchmarked weights.

To summarize:

Once Polkadot is on v1.0.0, we'll have to update the links to point to the fellowship PR.

This PR also updates the polkadot-sdk links on the fees page so that we point to v1.1.0, which is the version we migrated to as of RT2601.

You can double-check the calculated fees by looking at any xcKSM > KSM transaction that includes the instructions listed in the docs (WithdrawAsset, ClearOrigin, BuyExecution, and DepositAsset). For example:

Goes with CN PR: moonbeam-foundation/moonbeam-docs-cn#360

@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Nov 16, 2023
@eshaben eshaben requested a review from themacexpert November 16, 2023 02:41
@eshaben
Copy link
Contributor Author

eshaben commented Nov 16, 2023

Some of this overlaps with what I've done in the XCM overhaul. This PR just gets everything back to working order and then everything will be cleaned up in the XCM overhaul PR

Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

builders/interoperability/xcm/fees.md Outdated Show resolved Hide resolved
@eshaben eshaben merged commit 09224e3 into master Nov 17, 2023
1 check passed
@eshaben eshaben deleted the eshaben/kusama-v1.0.0-fees branch November 17, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants