Account for proof size when checking fee multiplier changes #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report@@ Coverage Diff @@
## master snowmead/fix-dynamic-fees-smoke-test +/- ##
=======================================================================
Coverage 74.35% 74.35% 0.00%
Files 384 384
Lines 97090 97090
=======================================================================
Hits 72190 72190
Misses 24900 24900
|
RomarQ
reviewed
Mar 12, 2025
RomarQ
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2428 KB (+8 KB) 🚨 Moonbeam runtime: 2404 KB (+4 KB) 🚨 Moonriver runtime: 2408 KB (-4 KB) 🚨 Compared to latest release (runtime-3501)Moonbase runtime: 2428 KB (+476 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+464 KB compared to latest release) 🚨 Moonriver runtime: 2408 KB (+468 KB compared to latest release) 🚨 |
snowmead
force-pushed
the
snowmead/fix-dynamic-fees-smoke-test
branch
from
3cc78d7 to
d611a1d
Compare
RomarQ
approved these changes
Mar 12, 2025
stiiifff
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes dynamic-fees smoke test which was previously only assuming that ref time was being used by the
TargetedFeeAdjustmentfrom pallet transaction-payment to determine theNextFeeMultiplier.Unifies weight validation between ref time and proof size, taking the limiting dimension to compare with the
targetWeight(known before astargetFillPermill).