Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert change for getting decimals in destination fees, due to an error #157

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

mmaurello
Copy link
Contributor

Description

Due to an error in uncontrolled cases, we revert the change that allowed to pay for fees in destination with an ERC20 by fetching decimals from contract

Checklist

  • If this requires a documentation change, I have created a PR in moonbeam-docs repository.
  • If this requires it, I have updated the Readme
  • If necessary, I have updated the examples
  • I have verified if I need to create/update unit tests
  • I have verified if I need to create/update acceptance tests
  • If necessary, I have run acceptance tests on this branch in CI

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: fb9d1a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@moonbeam-network/xcm-config Patch
@moonbeam-network/xcm-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Rihyx
Rihyx previously approved these changes Nov 2, 2023
@mmaurello mmaurello merged commit 7103bb0 into main Nov 2, 2023
3 checks passed
@mmaurello mmaurello deleted the mjm/revert-vdot-change branch November 2, 2023 14:21
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants