Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRL p3 #316

Merged
merged 37 commits into from
Aug 7, 2024
Merged

MRL p3 #316

merged 37 commits into from
Aug 7, 2024

Conversation

ekenigs
Copy link
Collaborator

@ekenigs ekenigs commented Jul 29, 2024

Description

  • ExtrinsicConfigBuilderPrams - refactoring
  • MrlExtrinsicConfigBuilderPrams
  • MrlExtrinsicBuilder
  • wh - config to Chain class

Checklist

  • If this requires a documentation change, I have created a PR that updates the mkdocs/docs directory
  • If this requires it, I have updated the Readme
  • If necessary, I have updated the examples
  • I have verified if I need to create/update unit tests
  • I have verified if I need to create/update acceptance tests
  • If necessary, I have run acceptance tests on this branch in CI

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 999edf8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ekenigs ekenigs changed the base branch from main to v3-next July 29, 2024 09:16
Copy link

socket-security bot commented Aug 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@wormhole-foundation/[email protected] environment 0 819 kB wormhole-ci

View full report↗︎

@ekenigs ekenigs marked this pull request as ready for review August 6, 2024 15:10
Copy link
Contributor

@mmaurello mmaurello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some questions and a couple of typos

Good job, I like how it is coming along

packages/sdk/src/sdk.ts Outdated Show resolved Hide resolved
packages/sdk/src/sdk.ts Outdated Show resolved Hide resolved
@ekenigs
Copy link
Collaborator Author

ekenigs commented Aug 7, 2024

@mmaurello please check again.

@ekenigs ekenigs merged commit ab95b21 into v3-next Aug 7, 2024
6 checks passed
@ekenigs ekenigs deleted the elmar/mrl-p3 branch August 7, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants