Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone redeeming capability #381

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Conversation

mmaurello
Copy link
Contributor

@mmaurello mmaurello commented Oct 24, 2024

  • Add function to complete transfer in wormhole
  • Add function to call the GMP contract to start the XCM transaction
  • Add AGNG route from Fantom to Peaq

NOTE: The redeeming functions are done considering that the provider is Wormhole, we either have to find a solution to specify it now, or later when we add more providers

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: f1db701

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "scripts" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@@ -41,3 +45,10 @@ export interface ChainTransferData {
fee: AssetAmount;
min: AssetAmount;
}

// TODO this is just for Wormhole
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what this comment means

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that the RedeemData only make sense if we consider that the provider is Wormhole. If you look at the properties (vaa, tokenTransfer), its types are from the wormhole-sdk. So if in the future we add another provider / bridge, this data will not make sense.
Not sure how to fix it for the moment

examples/mrl-simple/index.ts Show resolved Hide resolved
packages/mrl/src/mrl.ts Outdated Show resolved Hide resolved
@mmaurello mmaurello merged commit 4385bbe into v3-next Oct 29, 2024
7 checks passed
@mmaurello mmaurello deleted the v3-next-mrl-transfer-3 branch October 29, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants