-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standalone redeeming capability #381
Conversation
|
@@ -41,3 +45,10 @@ export interface ChainTransferData { | |||
fee: AssetAmount; | |||
min: AssetAmount; | |||
} | |||
|
|||
// TODO this is just for Wormhole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what this comment means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that the RedeemData only make sense if we consider that the provider is Wormhole. If you look at the properties (vaa, tokenTransfer), its types are from the wormhole-sdk. So if in the future we add another provider / bridge, this data will not make sense.
Not sure how to fix it for the moment
NOTE: The redeeming functions are done considering that the provider is Wormhole, we either have to find a solution to specify it now, or later when we add more providers