Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Redeem Wording #418

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Change Redeem Wording #418

merged 1 commit into from
Jan 7, 2025

Conversation

mmaurello
Copy link
Contributor

@mmaurello mmaurello commented Jan 4, 2025

I decided to stop using the term 'redeem' and change it to 'execute transfer' as I feel that Redeem is not always correct. It might be correct when transferring to EVM chains, where executing the transfer gives you the tokens. But when transferring to parachains, when executing the transfer a contract call to the GMP precompile occurs, so no actual redeeming.

Wormhole themselves also changed the wording a while back. For example, the status that they called PENDING REDEEM is now called PENDING EXECUTION

Copy link

changeset-bot bot commented Jan 4, 2025

⚠️ No Changeset found

Latest commit: eeede55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "scripts" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@mmaurello mmaurello merged commit d943d43 into v3-next Jan 7, 2025
8 checks passed
@mmaurello mmaurello deleted the v3-rename-redeem branch January 7, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants