Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network nodes - RPC & Archive #228

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

augustocollado
Copy link
Contributor

Description

This PR updates wording.
It's a draft, as it still needs a live testnet to update and test the instructions (chain specs, bootnodes, etc) against.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in tanssi-mkdocs to update redirects

@augustocollado augustocollado added A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) C2 - High High priority task labels Jan 20, 2025
--state-pruning=archive \
--blocks-pruning=archive \
--database=paritydb \
--unsafe-rpc-external \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we don't recommend --unsafe-rpc-external or is this a flag that OpsLayer confirmed can be used? I think this is not a great security practice, so if we were to add this it should be under a note or a warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a flag opslayer is actually using on stagelight. Atm, we only have a line explaining what it is for, but I'll also add a warning

Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments around unsafe rpc external

@@ -129,21 +129,18 @@ docker run -ti moondancelabs/dancebox-container-chain-evm-templates \
--name=para \
--state-pruning=archive \
--blocks-pruning=archive \
--database=paritydb \
--unsafe-rpc-external \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment with unsafe-rpc-external

@@ -160,7 +157,7 @@ docker run -ti moondancelabs/dancebox-container-chain-evm-templates \

## Syncing Your Node {: #syncing-your-node }

Once your node spins up, the syncing process displays lots of log information from the node configuration, the relay chain, and the node itself. Some errors are expected to be displayed at the beginning of the process, disappearing once the chain gets synced to the last block.
Once your node spins up, the syncing process displays lots of log information from the node itself and the Tanssi network. Some errors are expected to be displayed at the beginning of the process, disappearing once the chain gets synced to the last block.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once your node spins up, the syncing process displays lots of log information from the node itself and the Tanssi network. Some errors are expected to be displayed at the beginning of the process, disappearing once the chain gets synced to the last block.
Once your node spins up, the syncing process displays a lot of log information from both the node and the Tanssi network. Some errors are expected to be displayed at the beginning of the process, disappearing once the chain gets synced to the last block.

Copy link
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯 from the formatting perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) C2 - High High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants