Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Tanssi - Ethereum communication #235

Merged
merged 17 commits into from
Mar 12, 2025
Merged

docs: Tanssi - Ethereum communication #235

merged 17 commits into from
Mar 12, 2025

Conversation

ernestosperanza
Copy link
Contributor

@ernestosperanza ernestosperanza commented Feb 24, 2025

Description

This PR add some general context about the middleware and bridge architecture.
This explains how Tanssi, Ethereum and eventually Symbiotic communicate and interact.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in tanssi-mkdocs to update redirects

@ernestosperanza ernestosperanza added A0 - New Content Pull request contains new content pages B0 - Needs Review Pull request is ready for review labels Feb 24, 2025
@ernestosperanza ernestosperanza self-assigned this Feb 24, 2025
@ernestosperanza ernestosperanza requested a review from a team as a code owner February 24, 2025 19:00
@ernestosperanza ernestosperanza changed the title Ernest/middleware docs: Tanssi - Ethereum communication Feb 24, 2025
Copy link
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🥇 I left a few comments for improving the flow of the text by avoiding word repetition. As I mentioned in the comments, these are only suggestions. After @augustocollado reviews it for content, please keep this in mind when adding new information.

Copy link
Contributor

@augustocollado augustocollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observations

@ernestosperanza
Copy link
Contributor Author

@moondance-labs/devrel-formatting This PR is ready for review

Copy link
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee! 💯 Just a minor fix

@ernestosperanza ernestosperanza requested a review from 0xlukem March 10, 2025 17:08
augustocollado
augustocollado previously approved these changes Mar 10, 2025
Copy link
Contributor

@augustocollado augustocollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from ernest/symbiotic to main March 10, 2025 22:25
@eshaben eshaben dismissed augustocollado’s stale review March 10, 2025 22:25

The base branch was changed.

@ernestosperanza ernestosperanza requested a review from eshaben March 11, 2025 13:46
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeet, LGTM!

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Mar 12, 2025
@eshaben eshaben merged commit 7dceb1e into main Mar 12, 2025
2 checks passed
@eshaben eshaben deleted the ernest/middleware branch March 12, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages B1 - Ready to Merge Pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants