Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: vault section enhancement #239

Merged
merged 10 commits into from
Mar 12, 2025
Merged

feat: vault section enhancement #239

merged 10 commits into from
Mar 12, 2025
+18 −14

Conversation

ernestosperanza
Copy link
Contributor

@ernestosperanza ernestosperanza commented Mar 7, 2025 •
edited
Loading

Description

Please explain the changes this PR addresses here.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in tanssi-mkdocs to update redirects

@ernestosperanza ernestosperanza requested a review from a team as a code owner March 7, 2025 18:07
@ernestosperanza ernestosperanza changed the base branch from main to ernest/middleware March 7, 2025 18:07
@ernestosperanza ernestosperanza self-assigned this Mar 7, 2025
@ernestosperanza ernestosperanza added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review labels Mar 7, 2025
augustocollado
augustocollado requested changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@augustocollado augustocollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observations

@ernestosperanza
Copy link
Contributor Author

@moondance-labs/devrel-formatting this PR is ready to be reviewed, thanks 😄

0xlukem
0xlukem reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 👍 some minors fix

@ernestosperanza ernestosperanza requested a review from 0xlukem March 10, 2025 13:59
0xlukem
0xlukem approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@0xlukem 0xlukem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

augustocollado
augustocollado requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@augustocollado augustocollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

augustocollado
augustocollado previously approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@augustocollado augustocollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eshaben
eshaben reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things, but other than that it looks good!

@ernestosperanza ernestosperanza requested a review from eshaben March 11, 2025 13:10
eshaben
eshaben previously approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Mar 11, 2025
Base automatically changed from ernest/middleware to main March 12, 2025 02:31
@eshaben eshaben dismissed stale reviews from augustocollado and themself March 12, 2025 02:31

The base branch was changed.

@eshaben eshaben merged commit db68b54 into main Mar 12, 2025
@eshaben eshaben deleted the ernest/vault-summary branch March 12, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

@0xlukem 0xlukem 0xlukem approved these changes

@augustocollado augustocollado augustocollado left review comments

Assignees

@ernestosperanza ernestosperanza

Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ernestosperanza @eshaben @augustocollado @0xlukem