Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charCount #14

Merged
merged 2 commits into from
Dec 10, 2023
Merged

charCount #14

merged 2 commits into from
Dec 10, 2023

Conversation

lillithkt
Copy link
Contributor

No description provided.

@NotNite
Copy link
Member

NotNite commented Dec 10, 2023

You seem to have a case sensitivity issue with the folder versus extension ID - please resolve this.

@lillithkt
Copy link
Contributor Author

Fixed!

NotNite
NotNite approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@NotNite NotNite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This isn't a functional issue, so it's not required, but I would suggest updating your extensions such that the description is the tagline (given your extensions seem to have very short descriptions).

@NotNite NotNite merged commit 95c5e85 into moonlight-mod:main Dec 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotNite NotNite NotNite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lillithkt @NotNite