Merge pull request #1244 from moosetechnology/1243-SourceCodeBrowser-…

…opening-external-editor-on-windows 1243 source code browser opening external editor on windows
moosetechnology · Nov 22, 2024 · a81999b · a81999b
2 parents d52e015 + 88142ec
commit a81999b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/MooseIDE-Famix/MiExternalEditorOpenner.class.st b/src/MooseIDE-Famix/MiExternalEditorOpenner.class.st
@@ -47,9 +47,9 @@ MiExternalEditorOpenner >> pathString: anObject [
 
 { #category : #'private - ffi' }
 MiExternalEditorOpenner >> privShellExecute: lpOperation file: lpFile parameters: lpParameters directory: lpDirectory show: nShowCmd [
-	^ self ffiCall: #( 
+	^ self ffiCall: #(
 			FFIConstantHandle ShellExecuteA(
-     				0,
+     				int 0, "Operation is not associated with a window"
      				char* lpOperation,
          			char* lpFile,
      				char* lpParameters,
@@ -71,9 +71,9 @@ MiExternalEditorOpenner >> visitUnix: aPlatform [
 MiExternalEditorOpenner >> visitWindows: aPlatform [
 
 	self
-		privShellExecute: ''
-		file: command
+		privShellExecute: 'open'
+		file: ('"{1}"' format: { command })
 		parameters: ('"{1}"' format: { pathString })
 		directory: ''
-		show: 0 "SW_SHOW"
+		show: 5 "SW_SHOW : Activates the window and displays it in its current size and position."
 ]
diff --git a/src/MooseIDE-Famix/MiSourceTextExternalEditorIntellij.class.st b/src/MooseIDE-Famix/MiSourceTextExternalEditorIntellij.class.st
@@ -25,7 +25,7 @@ MiSourceTextExternalEditorIntellij class >> editorName [
 MiSourceTextExternalEditorIntellij class >> platformCommand [
 
 	^{ #Unix -> 'intellij-idea-ultimate' .
-	  #Windows -> 'idea64.exe' .
+	  #Windows -> 'idea64' .
 	  #MacOS -> 'idea' .
 	  #MacOSX -> 'idea' } asDictionary 
 		at: OSPlatform current family