Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1243 source code browser opening external editor on windows #1244

Merged
merged 3 commits into from
Nov 22, 2024
Merged

1243 source code browser opening external editor on windows #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73ed684
should fix the problem
Nov 22, 2024
6a8a982
fixing issue #1243
Nov 22, 2024
88142ec
Merge 73ed684079633646655a7fe8206044936bf8d59d
Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/MooseIDE-Famix/MiExternalEditorOpenner.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ MiExternalEditorOpenner >> pathString: anObject [

{ #category : #'private - ffi' }
MiExternalEditorOpenner >> privShellExecute: lpOperation file: lpFile parameters: lpParameters directory: lpDirectory show: nShowCmd [
^ self ffiCall: #(
^ self ffiCall: #(
FFIConstantHandle ShellExecuteA(
0,
int 0, "Operation is not associated with a window"
char* lpOperation,
char* lpFile,
char* lpParameters,
Expand All @@ -71,9 +71,9 @@ MiExternalEditorOpenner >> visitUnix: aPlatform [
MiExternalEditorOpenner >> visitWindows: aPlatform [

self
privShellExecute: ''
file: command
privShellExecute: 'open'
file: ('"{1}"' format: { command })
parameters: ('"{1}"' format: { pathString })
directory: ''
show: 0 "SW_SHOW"
show: 5 "SW_SHOW : Activates the window and displays it in its current size and position."
]
2 changes: 1 addition & 1 deletion src/MooseIDE-Famix/MiSourceTextExternalEditorIntellij.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ MiSourceTextExternalEditorIntellij class >> editorName [
MiSourceTextExternalEditorIntellij class >> platformCommand [

^{ #Unix -> 'intellij-idea-ultimate' .
#Windows -> 'idea64.exe' .
#Windows -> 'idea64' .
#MacOS -> 'idea' .
#MacOSX -> 'idea' } asDictionary
at: OSPlatform current family
Expand Down