Skip to content

Commit

Permalink
ci: update deps. (#193)
Browse files Browse the repository at this point in the history
* test: better playwright locator.
  • Loading branch information
morganney authored Jan 25, 2024
1 parent 84cde23 commit ff6fced
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3.5.2
uses: actions/checkout@v4.1.1
- name: Setup Node
uses: actions/setup-node@v3.6.0
uses: actions/setup-node@v4.0.1
with:
node-version: '20.10.0'
node-version: '20.11.0'
- name: Install Dependencies
run: npm ci
- name: Save error log
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4.3.0
if: ${{ failure() }}
with:
name: npm-debug-log-${{ hashFiles('package-lock.json') }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ jobs:
mkcert -key-file busmap.localhost-key.pem -cert-file busmap.localhost.pem busmap.localhost localhost
cp *.pem packages/web/certs
- name: Setup Node
uses: actions/setup-node@v3.6.0
uses: actions/setup-node@v4.0.1
with:
node-version: '20.10.0'
node-version: '20.11.0'
- name: Install Dependencies
run: npm ci
- name: Install Playwright
Expand All @@ -68,8 +68,8 @@ jobs:
SSO_GOOG_CLIENT_ID: ${{ secrets.SSO_GOOG_CLIENT_ID }}
SSO_GOOG_CLIENT_SECRET: ${{ secrets.SSO_GOOG_CLIENT_SECRET }}
- name: Upload Test Results
uses: actions/upload-artifact@v3
if: always()
uses: actions/upload-artifact@v4.3.0
if: failure()
with:
name: playwright-report
path: test-results
Expand Down
2 changes: 1 addition & 1 deletion tests/geolocation/deny.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test('Deny geolocation use selector to find stop.', async ({ page }) => {
await page.getByRole('listitem', { name: 'Selector' }).getByRole('button').click()
await expect(page.getByRole('heading', { name: 'Bus Selector' })).toBeVisible()
await page.getByText('Agency').click()
await page.getByPlaceholder('Agencies ... (64)').fill('toronto')
await page.getByLabel(/Agency/).fill('toronto')
await page.getByRole('option', { name: 'Toronto Transit Commission' }).click()
await page.getByText('Stop', { exact: true }).click()
await page.getByRole('option', { name: 'Bathurst St At Neptune Dr' }).click()
Expand Down

0 comments on commit ff6fced

Please sign in to comment.