Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic page title and desc. #152

Merged
merged 1 commit into from
Dec 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ui/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<title>Busmap</title>
<title>Busmap - Stop and vehicle locations of popular transit agencies.</title>
<meta
name="description"
content="Real-time arrival predictions with route and vehicle locations for bus stops in San Francisco Muni CIS, Toronto Transit Commission, OmniTrans and more." />
content="Maps providing real-time arrival and departure times of vehicles for bus stops along routes in San Francisco Muni CIS, Toronto Transit Commission, OmniTrans and other transit agencies across North and South America." />
<meta
name="viewport"
content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
Expand Down
6 changes: 6 additions & 0 deletions packages/ui/src/components/busSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { SelectorError } from './error/selector.js'

import { useGlobals } from '../globals.js'
import { useMap } from '../contexts/map.js'
import { useDocMeta } from '../hooks/useDocMeta.js'
import { useHomeStop } from '../hooks/useHomeStop.js'
import { useVehiclesDispatch } from '../contexts/vehicles.js'
import { getAll as getAllRoutes, get as getRoute } from '../api/rb/route.js'
Expand Down Expand Up @@ -157,6 +158,11 @@ const BusSelector = memo(function BusSelector({ agencies }: BusSelectorProps) {
const error = getFirstDataError([routesError, routeError])
const isLoading = isRoutesLoading || isRouteLoading

/**
* Update page title and description.
*/
useDocMeta()

useEffect(() => {
if (routes) {
if (bookmark.current.route) {
Expand Down
9 changes: 6 additions & 3 deletions packages/ui/src/components/busmap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ import type { FC } from 'react'
const BusmapPage: FC = () => {
return (
<Page title="About">
<p>
Busmap provides real-time arrival and departure times for vehicles servicing bus
stops along routes in San Francisco Muni CIS, Toronto Transit Commission,
OmniTrans, and other transit agencies across North and South America.
</p>
<p>
Busmap is a public, open source project{' '}
<a href="https://github.com/morganney/busmap" target="_blank" rel="noreferrer">
Expand All @@ -21,9 +26,7 @@ const BusmapPage: FC = () => {
<a href="http://restbus.info/" target="_blank" rel="noreferrer">
<code>restbus</code>
</a>
.
</p>
<p>
.{' '}
<a
href="https://github.com/morganney/busmap/pulls"
target="_blank"
Expand Down
8 changes: 4 additions & 4 deletions packages/ui/src/contexts/predictions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ interface PredictionsChanged {
type PredictionsAction = PredictionsChanged | StopChanged | DirectionChanged
interface PredictionsContext {
dispatch: Dispatch<PredictionsAction>
predictions?: Prediction[]
predictions: Prediction[]
}

const Predictions = createContext<PredictionsContext>({
dispatch: () => {},
predictions: undefined
predictions: []
})
const reducer = (state: Prediction[] | undefined, action: PredictionsAction) => {
const reducer = (state: Prediction[], action: PredictionsAction) => {
switch (action.type) {
case 'predictions':
return action.value
case 'direction':
case 'stop':
return undefined
return []
default:
return state
}
Expand Down
58 changes: 58 additions & 0 deletions packages/ui/src/hooks/useDocMeta.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { useEffect, useRef } from 'react'

import { useGlobals } from '../globals.js'
import { usePredictions } from '../contexts/predictions'

const useDocMeta = () => {
const metaDesc = useRef<Element>()
const { agency, stop } = useGlobals()
const { predictions } = usePredictions()

useEffect(() => {
const meta = document.querySelector('meta[name="description"]')

if (meta) {
metaDesc.current = meta
}
}, [])

useEffect(() => {
if (metaDesc.current) {
if (agency && stop) {
let event = 'arrival'
let title = `${stop.title}`

if (predictions.length) {
const [one, two] = predictions[0].values

if (one.isDeparture) {
event = 'departure'
}

title += `: ${one.minutes || 'Now'}`

if (two) {
title += ` & ${two.minutes || 'Now'}`
}

title += ' min'
}

document.title = title
metaDesc.current.setAttribute(
'content',
`Maps providing real-time ${event} times of vehicles for ${agency.title} stop ${stop.title}.`
)
} else {
document.title =
'Busmap - Stop and vehicle locations of popular transit agencies.'
metaDesc.current.setAttribute(
'content',
'Maps providing real-time arrival and departure times of vehicles for bus stops along routes in San Francisco Muni CIS, Toronto Transit Commission, OmniTrans and other transit agencies across North and South America.'
)
}
}
}, [agency, stop, predictions])
}

export { useDocMeta }
4 changes: 2 additions & 2 deletions packages/ui/src/hooks/useVehiclesLayer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,14 @@ const useVehiclesLayer = ({ vehiclesLayer }: UseVehiclesLayer) => {
useVehicleSettings()

const iconDimensions = useRef<Dimensions | null>(null)
const preds = useRef(predictions?.length ? predictions[0].values.slice(0, 3) : [])
const preds = useRef(predictions.length ? predictions[0].values.slice(0, 3) : [])

useEffect(() => {
iconDimensions.current = null
}, [route])

useEffect(() => {
const nextPreds = predictions?.length ? predictions[0].values.slice(0, 3) : []
const nextPreds = predictions.length ? predictions[0].values.slice(0, 3) : []

preds.current = nextPreds
}, [predictions])
Expand Down