Skip to content

Commit

Permalink
Fix/a corner case of remote workspace detection (#1183)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhenyu-ms authored Feb 19, 2025
1 parent 8a022e9 commit 68d2b7f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion testplan/common/remote/remote_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,10 @@ def _create_remote_dirs(self) -> None:
label="remove remote plan runpath",
)

# NOTE: corner case: runpath under workspace
# NOTE: should check existence before any mkdir call
exist_on_remote = self._check_workspace()

self._execute_cmd_remote(
cmd=mkdir_cmd(self._remote_plan_runpath),
label="create remote plan runpath",
Expand All @@ -290,7 +294,6 @@ def _create_remote_dirs(self) -> None:
# TODO: testplan_lib will resolved to site-packages under venv,
# TODO: while rpyc_classic.py under bin isn't included

exist_on_remote = self._check_workspace()
self._prepare_workspace(exist_on_remote)

# NOTE: if workspace under testplan_lib (testplan installed in
Expand Down

0 comments on commit 68d2b7f

Please sign in to comment.